-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base45): add base45 encode and decode #54
Conversation
Great! I am on leave and expect to review in early July. |
@wafer-li It would be great if we update the |
encoding/src/commonMain/kotlin/diglol/encoding/internal/commonBase45.kt
Outdated
Show resolved
Hide resolved
encoding/src/commonMain/kotlin/diglol/encoding/internal/commonBase45.kt
Outdated
Show resolved
Hide resolved
Roger. Since it is working hours in China, I will fix those issues tonight |
…diglol#55) Bumps [com.vanniktech:gradle-maven-publish-plugin](https://github.com/vanniktech/gradle-maven-publish-plugin) from 0.25.2 to 0.25.3. - [Release notes](https://github.com/vanniktech/gradle-maven-publish-plugin/releases) - [Changelog](https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md) - [Commits](vanniktech/gradle-maven-publish-plugin@0.25.2...0.25.3) --- updated-dependencies: - dependency-name: com.vanniktech:gradle-maven-publish-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Wired! It seems that the latest commit not synced to this PR, even if I already pushed fixed commits to the branch in my repo |
You could just review the existing fix commits, if it is necessary, I might have to close this PR and open another one. |
Don't worry, once it's done, it will be merged with |
encoding/src/commonMain/kotlin/diglol/encoding/internal/commonBase45.kt
Outdated
Show resolved
Hide resolved
encoding/src/commonMain/kotlin/diglol/encoding/internal/commonBase45.kt
Outdated
Show resolved
Hide resolved
encoding/src/commonMain/kotlin/diglol/encoding/internal/commonBase45.kt
Outdated
Show resolved
Hide resolved
Try to fix compile error in cc4bbb7 |
But not support URL Safe now, since the RFC document not providing a URL Safe char table.