Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base45): add base45 encode and decode #54

Merged
merged 28 commits into from
Jul 6, 2023

Conversation

wafer-li
Copy link
Contributor

But not support URL Safe now, since the RFC document not providing a URL Safe char table.

@robxyy
Copy link
Contributor

robxyy commented Jun 22, 2023

Great! I am on leave and expect to review in early July.

@robxyy
Copy link
Contributor

robxyy commented Jul 2, 2023

@wafer-li It would be great if we update the README and add Base45 samples. 🍺

@wafer-li
Copy link
Contributor Author

wafer-li commented Jul 3, 2023

Roger.

Since it is working hours in China, I will fix those issues tonight

…diglol#55)

Bumps [com.vanniktech:gradle-maven-publish-plugin](https://github.com/vanniktech/gradle-maven-publish-plugin) from 0.25.2 to 0.25.3.
- [Release notes](https://github.com/vanniktech/gradle-maven-publish-plugin/releases)
- [Changelog](https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md)
- [Commits](vanniktech/gradle-maven-publish-plugin@0.25.2...0.25.3)

---
updated-dependencies:
- dependency-name: com.vanniktech:gradle-maven-publish-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wafer-li added a commit to wafer-li/diglol-encoding that referenced this pull request Jul 5, 2023
wafer-li added a commit to wafer-li/diglol-encoding that referenced this pull request Jul 5, 2023
wafer-li added a commit to wafer-li/diglol-encoding that referenced this pull request Jul 5, 2023
wafer-li added a commit to wafer-li/diglol-encoding that referenced this pull request Jul 5, 2023
wafer-li added a commit to wafer-li/diglol-encoding that referenced this pull request Jul 5, 2023
@wafer-li
Copy link
Contributor Author

wafer-li commented Jul 5, 2023

Wired!

It seems that the latest commit not synced to this PR, even if I already pushed fixed commits to the branch in my repo

@wafer-li
Copy link
Contributor Author

wafer-li commented Jul 5, 2023

Wired!

It seems that the latest commit not synced to this PR, even if I already pushed fixed commits to the branch in my repo

You could just review the existing fix commits, if it is necessary, I might have to close this PR and open another one.

@robxyy
Copy link
Contributor

robxyy commented Jul 5, 2023

Wired!
It seems that the latest commit not synced to this PR, even if I already pushed fixed commits to the branch in my repo

You could just review the existing fix commits, if it is necessary, I might have to close this PR and open another one.

Don't worry, once it's done, it will be merged with Squash.

@wafer-li
Copy link
Contributor Author

wafer-li commented Jul 6, 2023

@wafer-li It would be great if we update the README and add Base45 samples. 🍺

Added README things in e024796

README.md Show resolved Hide resolved
@wafer-li
Copy link
Contributor Author

wafer-li commented Jul 6, 2023

Try to fix compile error in cc4bbb7

@robxyy robxyy merged commit bad7847 into diglol:trunk Jul 6, 2023
@wafer-li wafer-li deleted the feat-base45 branch July 6, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants