Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support for Custom Post Types and taxonomies #201

Merged
merged 15 commits into from
Jan 10, 2024

Conversation

raikasdev
Copy link
Member

@raikasdev raikasdev commented Sep 26, 2023

Adds a way to use Polylang translations with taxonomies and CPTs. Not 100% sure if this is the best way to implement this, reviews appreciated. It also fixes the issue with slugs not being generated with pll_translatable (issue #186), problem also reported to Polylang to see if it's on their side.

This requires changes to air-helper: an action named "after_air_helper_init", to make sure air-helper's language wrapper is available. PR shall be a draft, until that or similar functionality is ready (add_action init running after air-helper, checking if function is available?)

Closes #178
Closes #186

@height
Copy link

height bot commented Sep 26, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@raikasdev
Copy link
Member Author

Gotta fix the phpcs styling tomorrow

@raikasdev
Copy link
Member Author

No clue how to fix the "spaces before asterisk". Squash merge recommended because of the ugly commits.

@raikasdev raikasdev changed the title Feat/i18n tax cpt Add translation support for Custom Post Types and taxonomies Sep 29, 2023
@ronilaukkarinen ronilaukkarinen marked this pull request as ready for review January 10, 2024 14:02
@ronilaukkarinen ronilaukkarinen merged commit a668852 into digitoimistodude:master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate pll_translatable not working properly on taxonomies Make CPT & tax archive titles translatable
2 participants