-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation support for Custom Post Types and taxonomies #201
Merged
ronilaukkarinen
merged 15 commits into
digitoimistodude:master
from
raikasdev:feat/i18n-tax-cpt
Jan 10, 2024
Merged
Add translation support for Custom Post Types and taxonomies #201
ronilaukkarinen
merged 15 commits into
digitoimistodude:master
from
raikasdev:feat/i18n-tax-cpt
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gotta fix the phpcs styling tomorrow |
No clue how to fix the "spaces before asterisk". Squash merge recommended because of the ugly commits. |
raikasdev
changed the title
Feat/i18n tax cpt
Add translation support for Custom Post Types and taxonomies
Sep 29, 2023
ronilaukkarinen
added a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to use Polylang translations with taxonomies and CPTs. Not 100% sure if this is the best way to implement this, reviews appreciated. It also fixes the issue with slugs not being generated with pll_translatable (issue #186), problem also reported to Polylang to see if it's on their side.
This requires changes to air-helper: an action named "after_air_helper_init", to make sure air-helper's language wrapper is available. PR shall be a draft, until that or similar functionality is ready (add_action init running after air-helper, checking if function is available?)
Closes #178
Closes #186