Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring components #66

Draft
wants to merge 100 commits into
base: main
Choose a base branch
from
Draft

Refactoring components #66

wants to merge 100 commits into from

Conversation

Nautman
Copy link
Member

@Nautman Nautman commented Apr 1, 2021 •
edited
Loading

This fixes #54 .

Nautman added 30 commits April 1, 2021 22:14
@Nautman
Extracted API requests for sendLoginCode and register
f8755cf
@Nautman
Changed all instances of axios to API axios
3e6fe3c 
Also restructured the OpenPDF component
@Nautman
Added delete request to API instance + getAdmins + delete request
bc51e8a
@Nautman
Added ability to see applicant email
6fdf663
@Nautman
Added files slice
19dca2a
@Nautman
Refactored Upload to allow for greater customisation and reusability
4529fd5
@Nautman
Bug fix
9251468 
filesSlice was not operating correctly when deleting files
@Nautman
Added custom useAxios and improved admin hooks
352e3ae
@Nautman
Improved admin hooks
88998e4
@Nautman
Flattened admin file structure
2f075b6
@Nautman
Improved admin grading types and added useApi
3eba4b8
@Nautman
Restructured admi requests to api structure
bd1d8b1
@Nautman
Moved files and fixed errors
8885416
@Nautman
Merge branch 'add-applicant-information' into refactor
dd7c2ba
@Nautman
Created recommendationsSlice
7de6e09
@Nautman
Merge branch 'add-applicant-information' into refactor
0b5f3b7
@Nautman
Fixed warnings
ed304a6
@Nautman
Improved references
bc55805
@Nautman
Made axios calls into api calls
98765a1
@Nautman
Extracted Chapters and References from Portal
80b7a03
@Nautman
Extracted survey from portal
d2286bc
@Nautman
Extracted Introduction from portal
feb1952
@Nautman
Extracted survey hooks
4339b2e
@Nautman
Moved NoMatch
ab8cdd9
@Nautman
Extracted Reference
7ac9072
@Nautman
Improved redux state
58f476f 
Clearing files and recommendation information on logout
@Nautman
Added progress bars to two places
9674335
@Nautman
Changed name of FileChapters export
3b1b23d
@Nautman
Changed FileChapters into TranslatedChapters to improve resuability
cebfb45
@Nautman
Moved disabled loading logic from FileChapters to Upload feature
e409541
Nautman added 30 commits May 23, 2021 01:26
@Nautman
Removed unused default react logo
934c7e0
@Nautman
Moved logo to config folder
a349e2d
@Nautman
Moved portal translations to config and removed unnecessary translations
18f3b38 
There might be more unnecessary translations in the general UI translations as well as the application specific translations.
@Nautman
Fixed incorrect import in Logo
2e8b7dc
@Nautman
Added deadline to config
53ae5e5
@Nautman
Deleted unnecessary code in GradingView
17fedca
@Nautman
Simplified survey component
7f984c3 
By removing helpers in onSubmit prop
@Nautman
Began working on a custom survey feature
4a0632b
@Nautman
Fixed type bug in CustomSurvey story
56e2cc9
@Nautman
Added survey questions to config
1952416
@Nautman
Added select question type to survey type definitions
44cd895
@Nautman
Developed question type react components in CustomSurvey
534c77e
@Nautman
Added range translation and component to CustomSurvey
6092256
@Nautman
Separated CustomSurveyAccordion into a Form and Question
9fead6d
@Nautman
Added initialValues to CustomSurvey
ef3b802
@Nautman
Bug fix for initialValues in CustomSurvey
23fcd4d
@Nautman
Added submit button and required fields to CustomSurvey
f28bfdf
@Nautman
Made CustomSurveyAccordionProps the same as props for Form
f1316b1 
And thereby also fixing a type bug
@Nautman
Moved chapter JSON into chapters key in translations
901c9a2 
In the future this will allow for better customisation
@Nautman
Began to make config even more customizable
6a11d5b 
Moved the survey config within a chapter. This would potentially allow for multiple surveys within an application.
@Nautman
Began working on more customisable Chapters
e4d1b6c
@Nautman
Made the Chapter show a Survey instead of a FileChapter, for now
2978c2e
@Nautman
Added RecommendationChapter to custom chapters
a52ae0b
@Nautman
Fixed bug
13f2463 
The "max" prop in RecommendationChapter did not have a default value
@Nautman
Began implementing the CustomSurvey in reality
aae2223
@Nautman
Temporary solution to include survey in application
1eee68f 
This is temporary because the chapters should be customised in the future
@Nautman
Bug fix
08f0e58 
The questions were not actually given in the config
@Nautman
Switched out FileType in favour of a custom id
cd614a6
@Nautman
Fixed duplicate chapter descriptions and added initialValues to survey
fe48ef4
@Nautman
Removed unused uncustomised FileChapters and SurveyChapter
a0fd4b8 
Replaced by customisable chapters in Chapters.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract API requests and make them easier to change
2 participants
@Nautman @Zigolox