Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo and GitHub link to footer #44

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Logo and GitHub link to footer #44

wants to merge 3 commits into from

Conversation

Nautman
Copy link
Member

@Nautman Nautman commented Mar 6, 2021

No description provided.

@Nautman Nautman marked this pull request as ready for review March 7, 2021 17:03
@Nautman
Copy link
Member Author

Nautman commented Mar 7, 2021

This closes #18 and #4.

EDIT: It would be really kind if you could review this soon @Zigolox.

@Nautman Nautman requested a review from Zigolox March 7, 2021 17:04
@sakerhetspolisen
Copy link
Member

Don't know how much extra hassle this will be for you guys, but I think this would look awesome:

Skärmavbild 2021-03-07 kl  21 09 47

@sakerhetspolisen
Copy link
Member

Minified identicons:

identicons

@Zigolox
Copy link
Member

Zigolox commented Mar 7, 2021

Wow, that would look really cool! Perhaps it could be just an single anna identicon to begin with but when moving near the area they slide out like some Matryoshka dolls. lol

@sakerhetspolisen
Copy link
Member

Wow, that would look really cool! Perhaps it could be just an single anna identicon to begin with but when moving near the area they slide out like some Matryoshka dolls. lol

Awesome idea @Zigolox, I think that would look really cool haha

@Nautman
Copy link
Member Author

Nautman commented Mar 7, 2021

I really love your suggestion @sakerhetspolisen !!! If you would minimize / minify it somehow, how would you go about it?

I think the idea of the bots sliding out when hovering is a great idea.

I think perhaps the "explore source code" should not be a button, since a button makes users think that it's an action that they should do. Perhaps one could change the color of the button to be grey? What do you think?

@Zigolox
Copy link
Member

Zigolox commented Mar 7, 2021

How hard would it be to make the bots party, i.e. keeping the same face but their border changes colour?

@Nautman
Copy link
Member Author

Nautman commented Mar 7, 2021

Do you mean that their border color would change with some animation? It might be a bit laggy. However, one could probably make a PR to the bot-identicon package and make it so that the CSS color can override the border color. CSS animations are very performant.

@sakerhetspolisen
Copy link
Member

You are right. I would make change the "Utforska källkod" text color to something like #454545, and the background to #E8E8E8. Then I would make the image an mp4 file (smaller than gif) with the identicons kind of fading in from left. This mp4 video would then loop once so that on page load the user is greeted with a beautiful animation.

@sakerhetspolisen
Copy link
Member

Do we have dark mode on Infra Rays as well?

@Zigolox
Copy link
Member

Zigolox commented Mar 7, 2021

Do we have dark mode on Infra Rays as well?

No, although it would be nice

EDIT: added an issue for it #48

@sakerhetspolisen
Copy link
Member

If we implement this footer on digitalungdom.se e.g. we could either use CSS animations or a gif because now that I think of it mp4 doesn't support transparent background

@Zigolox
Copy link
Member

Zigolox commented Mar 11, 2021

@Nautman do we want to add the animation in this PR?

@Nautman
Copy link
Member Author

Nautman commented Mar 11, 2021

I don't think I can do an animation this year unfortunately. So it's up to you to decide if you want the logo and the source code link. I can remove the logo if that would make it better.

EDIT:

image

image

@Zigolox
Copy link
Member

Zigolox commented Mar 11, 2021

@sakerhetspolisen What do you think we should do for a simple logo right now?

@sakerhetspolisen
Copy link
Member

Maybe use the file I sent and make it smaller in relation to the text? And then we add the animation later.

@sakerhetspolisen
Copy link
Member

Maybe this works? Pretty small file (83K) minified.

footerlogo

@Nautman
Copy link
Member Author

Nautman commented Mar 13, 2021

That looks cool @sakerhetspolisen! Unfortunately I don't really have time to experiment with this for a while. It is up to the rest of you to decide if you want to merge the current state or wait. As previously stated I can also remove the logo for now.

@Zigolox
Copy link
Member

Zigolox commented Mar 23, 2021

Could we perhaps use the GitHub logo instead?

@Zigolox
Copy link
Member

Zigolox commented Mar 12, 2022

Bump! Now when we have merged PR on Nätklok we might be able to use assets from that for this

@sakerhetspolisen
Copy link
Member

sakerhetspolisen commented Mar 14, 2022

Good idea! Nätklok's component code can be found here, there's also an SVG that pops up on hover which can be found here. Perhaps we should make the logo into a package so that it can be used without effort in future projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants