Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensearch_config: follow PATCH semantics #1273

Merged
merged 2 commits into from
Nov 22, 2024
Merged

opensearch_config: follow PATCH semantics #1273

merged 2 commits into from
Nov 22, 2024

Conversation

andrewsomething
Copy link
Member

@andrewsomething andrewsomething commented Nov 21, 2024 •
edited
Loading

This change makes it so that we only send attributes that have changes for Opensearch configurations. The one exception is for the ISM-related settings. The API seems to require that they are sent together, e.g.:

 Error: Error updating Opensearch configuration: PATCH https://api.digitalocean.com/v2/databases/f3587545-9002-415b-9593-8473bc770a98/config: 422 (request "41520d54-cf5e-408d-ae19-e4fd45c310fa") invalid 'user_config': invalid input for opensearch: 'ism_history_enabled' is a required property

We may want to consider making similar changes for the other database engines. Though that is less pressing. The main motivator here is working around the bug triggered by sending override_main_response_version.

Fixes: #1272

@andrewsomething andrewsomething requested a review from a team November 21, 2024 23:28
loosla
loosla approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you

@andrewsomething andrewsomething merged commit 054313d into main Nov 22, 2024
3 checks passed
@andrewsomething andrewsomething deleted the asb/issues/1272 branch November 22, 2024 15:30
@brianhelba brianhelba mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosla loosla loosla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

digitalocean_database_opensearch_config touches unnecessary options on change
2 participants
@andrewsomething @loosla