opensearch_config: only send PATCH on create if values set. #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
commented
Nov 16, 2024
Comment on lines
-29
to
+31
| Config: fmt.Sprintf(testAccCheckDigitalOceanDatabaseOpensearchConfigConfigBasic, dbConfig, false, 1, "9223372036854775807"), | ||
| Config: fmt.Sprintf(testAccCheckDigitalOceanDatabaseOpensearchConfigConfigBasic, dbConfig, false, 1, "1000000000000000000"), |
There was a problem hiding this comment.
We're hitting a bug with upstream Terraform here. I've change this to another value to allow us to test the broader functionality despite this.
andrewsomething
commented
Nov 16, 2024
Comment on lines
+23
to
+25
| resource.TestCheckResourceAttr("digitalocean_database_opensearch_config.foobar", "enable_security_audit", "true"), | ||
| resource.TestCheckResourceAttr("digitalocean_database_opensearch_config.foobar", "ism_enabled", "true"), | ||
| resource.TestCheckResourceAttr("digitalocean_database_opensearch_config.foobar", "ism_history_enabled", "true"), |
There was a problem hiding this comment.
Apparently both ism_enabled and ism_history_enabled must be true when setting the other ism_history settings or the API returns errors, e.g.
Error: Error updating Opensearch configuration: PATCH https://api.digitalocean.com/v2/databases/d6b65b4f-954d-4ee0-a29b-29eb2b4d228f/config: 422 (request "7f2461f9-6c49-4291-a304-364f1d5eb740") invalid 'user_config': invalid input for opensearch: 'ism_history_enabled' is a required property
I've added enable_security_audit so that we have another bool value to test changes. This exposed the other bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1266, "creating" a
digitalocean_database_opensearch_configwithout any setting leads to an error. This change protects against that by preventing sending the PATCH on create if no other values besidecluster_idare set.Additionally, I ran into some issue running the acceptance test. One is a bug. We need to use
GetOkExistswhen checking the value for a bool. If not, it is not correctly detected when being set tofalse.There are also a few changes to the test that do not impact functionality which I will note inline.