Configure Godo Retryable HTTP Client

[danaelhe]

Update terraform-provider to use godo's retryable http client.

When the retryable feature is not set or set to 0 (DIGITALOCEAN_HTTP_RETRY_MAX=0 ) and you reach the 250 req/min threshold- you are met with a 429 error:

│ Error: Error retrieving Database User: GET https://api.digitalocean.com/v2/databases/f7ce-4843-a0d9/users/86-app: 429 (request "adfaa613-e244-4cb1-aa4d-bd82d14bef7b") Too many requests

When the retryable feature is set (DIGITALOCEAN_HTTP_RETRY_MAX=2 ) and you reach the 250 req/min threshold- the client performs automatic retries and exponential backoff and continues:

2023-08-08T15:13:01.396-0400 [DEBUG] provider.terraform-provider-digitalocean: 2023/08/08 15:13:01 [DEBUG] GET https://api.digitalocean.com/v2/databases/7d76-48e3-/users/173-app (status: 429): retrying in 44s (3 left)

The retryable feature to be on by default, with 4 tries.

[danaelhe]

I'm curious if we should make this the default behavior (maybe set DIGITALOCEAN_HTTP_RETRY_MAX=2 as default).

[danaelhe]

I'm curious if we should make this the default behavior (maybe set DIGITALOCEAN_HTTP_RETRY_MAX=2 as default).

After team discussion, I've made the retryable feature to be on by default with DIGITALOCEAN_HTTP_RETRY_MAX=4.

[andrewsomething]

Raising this to the top in case you missed my comment in the thread.

With the changes we've made to godo, we should be able to remove this bit:

client.Transport = &oauth2.Transport{
	Base:   client.Transport,
	Source: oauth2.ReuseTokenSource(nil, tokenSrc),
}

[danaelhe]

Raising this to the top in case you missed my comment in the thread.

With the changes we've made to godo, we should be able to remove this bit:

client.Transport = &oauth2.Transport{
	Base:   client.Transport,
	Source: oauth2.ReuseTokenSource(nil, tokenSrc),
}

oh yes thank you! Missed this somehow.

[andrewsomething]

🎉 LGTM!