Filters component update #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix border color on down and delete key -1 splice triggering results count.
- Colour of lines is inconsistent - Fix component column sizing on mobile - Remove left functionality - Rename examples - Fix active icon when filters are selected
- [X] Fix focus state on hover/click/active
- [X] Get rid of cancel border-top light colour on down
- [X] Rename bug 'Down Collapsed (no counter)'
- [X] Remove 'nsw-filters--collapsed' style as it is not used or necessary
- [X] nocount = 'true'
- [X] Remove subnav {{id}} as it is not used or necessary
- [X] Remove dashes in .json
- [X] Rename 'unique-id' to 'filters-id'
- [X] Add @link-button variable functionality to accordion / Fix based on accordion focus
- [X] Material-icon styles need to be nested
- [X] Refactor sass reordering common/shared properties to top
- [X] Remove 'transform: none' on check icon and instead add >.nsw-material-icons:last-child which will target the DIRECT children only
- [X] Replace Material icons 'font-size: rem(17px);' with font-size: rem(map-get($nsw-icon-sizes, 20));
- [X] Replace 'transition: 0.3s linear;' with $nsw-transition-duration
- [X] Update Guidance with new content
ALL must be clear before tick is removed and counter is updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.