Card full modifier #177
Merged
Card full modifier #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Pulling down to have a look now - thanks! |
elgandoz
commented
Nov 8, 2021
| @@ -5,8 +5,7 @@ | |||
| overflow: hidden; | |||
| height: 100%; | |||
| color: var(--nsw-text-dark); | |||
| border-top-left-radius: var(--nsw-border-radius); | |||
| border-top-right-radius: var(--nsw-border-radius); | |||
| border-radius: var(--nsw-border-radius); | |||
There was a problem hiding this comment.
This is mainly to fix the focus outline to be rounded at the bottom as well, for consistency with the rest of the components.
elgandoz
commented
Nov 8, 2021
elgandoz
commented
Nov 8, 2021
elgandoz
commented
Nov 8, 2021
src/components/card/index.hbs
Outdated
| {{#>_docs-example}} | ||
| <div class="nsw-grid"> | ||
| <div class="nsw-col nsw-col-lg-6"> | ||
| {{>_card model.card-image-1 full=true}} |
There was a problem hiding this comment.
I didn't pick the modifier name "full", probably we can come with something easier to grasp, unless you're happy with that
There was a problem hiding this comment.
I'll tag in @amy-howard on this one, she might have a name in mind
elgandoz
commented
Nov 8, 2021
elgandoz
force-pushed
the
master
branch
2 times, most recently
from
5f0c838 to
4b295b1
Compare
|
Merging into feature branch for name change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds card
nsw-card--fullmodifier class, as per requirement in nsw.gov.au.Also fixes the border bottom radius for focus state in all the cards.
The card full modifier displays best if max 2 card are available, and it respects the other modifiers.
On mobile, they look exactly as regular cards.
NB: starterkit not updated!