Fixing image sizing when outside the grid (#139)

* Fixing image sizing when outside the grid * fix: pa11y error * fix: pa11y warning * refactor image height to allow scaling * revert fix Co-authored-by: Anna Yeshtukova <> Co-authored-by: Benjamin Chiong <[email protected]>
digitalnsw · Apr 19, 2021 · de74bd2 · de74bd2
1 parent a00eafe
commit de74bd2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/components/banner/_banner.hbs b/src/components/banner/_banner.hbs
@@ -20,7 +20,7 @@
       </div>
       {{/if}}
 
-      <div class="nsw-banner__box" role="presentation">
+      <div class="nsw-banner__box"  {{#unless img}}role="presentation"{{/unless}}>
         {{#if img}}
         <img class="nsw-banner__image" src="{{img}}" alt="" />
         {{else}}

diff --git a/src/components/content-block/_content-block.scss b/src/components/content-block/_content-block.scss
@@ -4,7 +4,6 @@
   display: flex;
   flex-direction: column;
   overflow: hidden;
-  height: 100%;
 
   &__title {
     @include font-stack('heading');
@@ -67,7 +66,7 @@
 
   &__image {
     width: 100%;
-    height: 100%;
+    height: rem(200px);
     object-fit: cover;
   }