Fixed migration generator suggesting IHP.PGListener's triggers in the…

… migration
digitallyinduced · Apr 19, 2023 · c693558 · c693558
1 parent e0e1aa0
commit c693558
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/IHP/IDE/CodeGen/MigrationGenerator.hs b/IHP/IDE/CodeGen/MigrationGenerator.hs
@@ -192,6 +192,7 @@ removeNoise = filter \case
         StatementCreateTable { unsafeGetCreateTable = CreateTable { name = "schema_migrations" } }      -> False
         AddConstraint { tableName = "schema_migrations" }                                               -> False
         CreateFunction { functionName } | "notify_" `Text.isPrefixOf` functionName                      -> False
+        CreateTrigger { name } | "did_update_" `Text.isPrefixOf` name                                   -> False
         StatementCreateTable { unsafeGetCreateTable = CreateTable { name = "large_pg_notifications" } } -> False
         CreateIndex { tableName = "large_pg_notifications" }                                            -> False
         _                                                                                               -> True

diff --git a/Test/IDE/CodeGeneration/MigrationGenerator.hs b/Test/IDE/CodeGeneration/MigrationGenerator.hs
@@ -1351,6 +1351,15 @@ CREATE POLICY "Users can read and edit their own record" ON public.users USING (
 
                 diffSchemas targetSchema actualSchema `shouldBe` migration
 
+            it "should ignore did_update_.. triggers by IHP.PGListener" do
+                let actualSchema = sql $ cs [plain|
+                    CREATE TRIGGER did_update_plans AFTER UPDATE ON public.plans FOR EACH ROW EXECUTE FUNCTION public.notify_did_change_plans();
+                |]
+                let targetSchema = []
+                let migration = []
+
+                diffSchemas targetSchema actualSchema `shouldBe` migration
+
 sql :: Text -> [Statement]
 sql code = case Megaparsec.runParser Parser.parseDDL "" code of
     Left parsingFailed -> error (cs $ Megaparsec.errorBundlePretty parsingFailed)