Fixed migrations not normalising SERIAL and BIGSERIAL columns

digitallyinduced · Jan 11, 2022 · 9790756 · 9790756
1 parent e3a5c8f
commit 9790756
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 0 deletions.
diff --git a/IHP/IDE/CodeGen/MigrationGenerator.hs b/IHP/IDE/CodeGen/MigrationGenerator.hs
@@ -436,6 +436,8 @@ normalizeExpression (ExistsExpression a) = ExistsExpression (normalizeExpression
 
 normalizeSqlType :: PostgresType -> PostgresType
 normalizeSqlType (PCustomType customType) = PCustomType (Text.toLower customType)
+normalizeSqlType PBigserial = PBigInt
+normalizeSqlType PSerial = PInt
 normalizeSqlType otherwise = otherwise
 
 migrationPathFromPlan :: [GeneratorAction] -> Text

diff --git a/Test/IDE/CodeGeneration/MigrationGenerator.hs b/Test/IDE/CodeGeneration/MigrationGenerator.hs
@@ -729,6 +729,54 @@ tests = do
 
                 diffSchemas targetSchema actualSchema `shouldBe` []
 
+            it "should normalize Bigserials" do
+                let targetSchema = sql [i|
+                    CREATE TABLE testserial (
+                        testcol BIGSERIAL NOT NULL
+                    );
+                |]
+                let actualSchema = sql [i|
+                    CREATE TABLE public.testserial (
+                        testcol bigint NOT NULL
+                    );
+
+                    CREATE SEQUENCE public.testserial_testcol_seq
+                        START WITH 1
+                        INCREMENT BY 1
+                        NO MINVALUE
+                        NO MAXVALUE
+                        CACHE 1;
+
+                    ALTER SEQUENCE public.testserial_testcol_seq OWNED BY public.testserial.testcol;
+                    ALTER TABLE ONLY public.testserial ALTER COLUMN testcol SET DEFAULT nextval('public.testserial_testcol_seq'::regclass);
+                |]
+
+                diffSchemas targetSchema actualSchema `shouldBe` []
+
+            it "should normalize Serials" do
+                let targetSchema = sql [i|
+                    CREATE TABLE testserial (
+                        testcol SERIAL NOT NULL
+                    );
+                |]
+                let actualSchema = sql [i|
+                    CREATE TABLE public.testserial (
+                        testcol int NOT NULL
+                    );
+
+                    CREATE SEQUENCE public.testserial_testcol_seq
+                        START WITH 1
+                        INCREMENT BY 1
+                        NO MINVALUE
+                        NO MAXVALUE
+                        CACHE 1;
+
+                    ALTER SEQUENCE public.testserial_testcol_seq OWNED BY public.testserial.testcol;
+                    ALTER TABLE ONLY public.testserial ALTER COLUMN testcol SET DEFAULT nextval('public.testserial_testcol_seq'::regclass);
+                |]
+
+                diffSchemas targetSchema actualSchema `shouldBe` []
+
 
 sql :: Text -> [Statement]
 sql code = case Megaparsec.runParser Parser.parseDDL "" code of