HSX: Support underscores in data attribute names

digitallyinduced · May 26, 2022 · 5e772f6 · 5e772f6
1 parent 1ff977d
commit 5e772f6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Test/HSX/ParserSpec.hs b/Test/HSX/ParserSpec.hs
@@ -62,3 +62,7 @@ tests = do
             let p = parseHsx position "<div {...variables}/>"
             -- We cannot easily construct the @VarE variables@ expression, therefore we use show here for comparison
             tshow p `shouldBe` "Right (Children [Node \"div\" [SpreadAttributes (VarE variables)] [] False])"
+
+        it "should accept underscores in data attributes" do
+            let p = parseHsx position "<div data-client_id=\"test\"/>"
+            p `shouldBe` (Right (Children [Node "div" [StaticAttribute "data-client_id" (TextValue "test")] [] False]))
diff --git a/ihp-hsx/IHP/HSX/Parser.hs b/ihp-hsx/IHP/HSX/Parser.hs
@@ -195,7 +195,7 @@ hsxAttributeName = do
             || "hx-" `Text.isPrefixOf` name
             || name `Set.member` attributes
 
-        rawAttribute = takeWhile1P Nothing (\c -> Char.isAlphaNum c || c == '-')
+        rawAttribute = takeWhile1P Nothing (\c -> Char.isAlphaNum c || c == '-' || c == '_')
 
 
 hsxQuotedValue :: Parser AttributeValue