Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2428: Remove manual multidexing, Jetifier & deprecated package attribute #2503

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

sarahsporck
Copy link
Contributor

Short description

This PR removes some unused configurations from our gradle setup:

Proposed changes

  • remove jetifier
  • remove multidexing
  • remove package name

Resolved issues

Fixes: #2428


@sarahsporck sarahsporck changed the title 2428: remove manual multidexing, Jetifier & deprecated package attribute 2428: Remove manual multidexing, Jetifier & deprecated package attribute Oct 5, 2023
@sarahsporck sarahsporck linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see android.enableJetifier=true in the gradle.properties, does that one also have to go?

@sarahsporck
Copy link
Contributor Author

I also see android.enableJetifier=true in the gradle.properties, does that one also have to go?

Sadly this cannot go yet, as some of our dependencies still use android.support libraries, and this migrates them to androidx.

@sarahsporck sarahsporck merged commit acede47 into main Oct 7, 2023
4 checks passed
@sarahsporck sarahsporck deleted the 2428-remove-dexing-for-android-builds branch October 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dexing for android builds
3 participants