Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

900: add field nuernberg pass id & add new pdf template #977

Merged
merged 7 commits into from
May 24, 2023
Merged

900: add field nuernberg pass id & add new pdf template #977

merged 7 commits into from
May 24, 2023

Conversation

sarahsporck
Copy link
Contributor

No description provided.

@sarahsporck sarahsporck mentioned this pull request May 23, 2023
Closed
@sarahsporck sarahsporck force-pushed the 900-add-field-nuernberg-pass-id branch from 61e3860 to 6348adf Compare May 23, 2023 07:48
@sarahsporck sarahsporck linked an issue May 23, 2023 that may be closed by this pull request
[Sozialpass] Additional Field Nürnberg-Pass-Id on PDF #900
Closed
michael-markl
michael-markl approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested

administration/src/cards/pdf/PdfDetailElement.ts Outdated Show resolved Hide resolved
administration/src/project-configs/getProjectConfig.ts Outdated Show resolved Hide resolved
administration/src/cards/pdf/PdfElements.ts Outdated Show resolved Hide resolved
f1sh1918
f1sh1918 requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice refactoring. Looks so much cleaner. But there is an error in the pdf. One bigger and one minor thing.

1.The pass-id should be on the back of the print card and the pass-number on the front.

image
  1. The label in the form is wrong here (Nürnberg)
image

@f1sh1918 f1sh1918 self-requested a review May 23, 2023 20:26
@sarahsporck sarahsporck force-pushed the 900-add-field-nuernberg-pass-id branch 2 times, most recently from 18a3cff to 379fae8 Compare May 24, 2023 07:59
@f1sh1918 f1sh1918 mentioned this pull request May 24, 2023
Closed
f1sh1918
f1sh1918 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some wrong import. the rest is fine :)

@sarahsporck sarahsporck force-pushed the 900-add-field-nuernberg-pass-id branch from 98e2ffb to 08a51ce Compare May 24, 2023 09:29
@sarahsporck sarahsporck enabled auto-merge May 24, 2023 09:30
@steffenkleinle
Copy link
Member

Does this fix #783?

@sarahsporck sarahsporck merged commit 48ff72c into main May 24, 2023
@sarahsporck sarahsporck deleted the 900-add-field-nuernberg-pass-id branch May 24, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@michael-markl michael-markl michael-markl approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sozialpass] Additional Field Nürnberg-Pass-Id on PDF
4 participants
@sarahsporck @steffenkleinle @michael-markl @f1sh1918