New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for printing #939

Merged

f1sh1918 merged 1 commit into 885-Application-pdf-export from 885-mm

Apr 12, 2023

Member

michael-markl commented Apr 12, 2023 •

edited

Loading

@f1sh1918 : When testing #937 I noticed a few minor quirks:

When canceling the print dialog, I could not restart it (on the same application).
Minor visuals: Everything centered, weird boxshadow, wrong text for attachments

This was my attempt to fixing these on the fly. I also refactored very slightly. Feel free to take these suggestions into your PR.


          Minor improvements for printing

f8718d3

michael-markl requested review from maxammann and steffenkleinle as code owners

April 12, 2023 19:24

Contributor

f1sh1918 commented Apr 12, 2023

@f1sh1918 : When testing #937 I noticed a few minor quirks:

When canceling the print dialog, I could not restart it (on the same application).

Minor visuals: Everything centered, weird boxshadow, wrong text for attachments

This was my attempt to fixing these on the fly. I also refactored very slightly. Feel free to take these suggestions into your PR.

Alright this is way easier thx. Seems like the event listener is only working for chrome, because i faced the same issue before. but in this case not really needed, nice.

gonna merge it

f1sh1918 merged commit 35672fe into 885-Application-pdf-export

f1sh1918 deleted the 885-mm branch

April 12, 2023 19:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet