856: Add health check endpoint #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsporck
commented
Mar 15, 2023
| } | ||
| } | ||
| ctx.status(200) | ||
| } catch (exception: ExposedSQLException) { |
There was a problem hiding this comment.
It could also make sense to change this to exception: Exception, to increase the resilience of this endpoint.
There was a problem hiding this comment.
As you want. Probably any other exception will also return some status != 200.
There was a problem hiding this comment.
you're right. Otherwise it will return 500 Internal Server Error
michael-markl
approved these changes
Mar 15, 2023
backend/src/main/kotlin/app/ehrenamtskarte/backend/common/webservice/HealthHandler.kt
Show resolved
Hide resolved
| } | ||
| } | ||
| ctx.status(200) | ||
| } catch (exception: ExposedSQLException) { |
There was a problem hiding this comment.
As you want. Probably any other exception will also return some status != 200.
sarahsporck
force-pushed
the
856-add-health-check-endpoint
branch
2 times, most recently
from
71c0686 to
c59edce
Compare
sarahsporck
force-pushed
the
856-add-health-check-endpoint
branch
from
c59edce to
2fd763d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with:
curl http://localhost:8000/health --verbose