Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend #848

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Upgrade frontend #848

merged 5 commits into from
Mar 13, 2023

Conversation

michael-markl
Copy link
Member

@michael-markl michael-markl commented Mar 4, 2023

Upgrades Flutter to v3.7.
Make sure to run fvm install after this PR is merged

Some smoke testing on iOS would be great!

@michael-markl michael-markl marked this pull request as ready for review March 4, 2023 13:52
Copy link
Contributor

@sarahsporck sarahsporck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running flutter pub get the lock file changes for me. Something related to mobile_scanner 3.0.0 from git https://github.com/michael-markl/mobile_scanner.git at 4bdbbc (was 3.0.0 from git https://github.com/michael-markl/mobile_scanner.git at 3a4f39)
Also sth. is not right with the clusters. They seem to overlap:

Also the category filters don't seem to work:

frontend/lib/themes.dart Show resolved Hide resolved
@michael-markl
Copy link
Member Author

michael-markl commented Mar 6, 2023

When running flutter pub get the lock file changes for me. Something related to mobile_scanner 3.0.0 from git https://github.com/michael-markl/mobile_scanner.git at 4bdbbc (was 3.0.0 from git https://github.com/michael-markl/mobile_scanner.git at 3a4f39)

It seems you're right! We should adjust the CI to fail in that case...

Also sth. is not right with the clusters. They seem to overlap:

The clusters on your screesnhots are the "normal" ones that we have for Nürnberg when you zoom out a lot. Maybe you mixed up project configs somehow in your build? 🤔

Also the category filters don't seem to work:

Not sure why this does not work... Again it seems to me like a local setup issue 🤔 I will check again once I have time whether I can reproduce this.

@sarahsporck
Copy link
Contributor

The clusters on your screesnhots are the "normal" ones that we have for Nürnberg when you zoom out a lot. Maybe you mixed up project configs somehow in your build? 🤔

Hmm, I guess you're right. I also had the feeling sth. was off. I'll take another look at my setup.

@sarahsporck
Copy link
Contributor

Okay I got it working. Not sure what didn't work though... I'll update the pods for you.

@michael-markl
Copy link
Member Author

michael-markl commented Mar 6, 2023

Thanks! While you're at it, could you also update the lock file for flutter pub?

Ah nvmd, you probably already switched to a different branch :D

@michael-markl
Copy link
Member Author

@sarahsporck Did you also try scanning a code on iOS? If yes, I think we can merge this (unless you have other questions/concerns) :D

@sarahsporck
Copy link
Contributor

@sarahsporck Did you also try scanning a code on iOS? If yes, I think we can merge this (unless you have other questions/concerns) :D

Sadly, I don't have an iOS device of my own, so far. And when i tried installing it on the device in the projektraum I had some trouble with provisioning profiles. However, @f1sh1918 can test it when he comes back from vacation on monday :)

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ios real device. no issues found. nice :)

@michael-markl michael-markl merged commit ac868ba into main Mar 13, 2023
@michael-markl michael-markl deleted the upgrade-frontend branch March 13, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants