675: Add support for static qr codes in frontend #747
Conversation
There was a problem hiding this comment.
This is probably missing in the issue description, but I think we agreed on the following:
In the case, a static card is being verified, the user (the verifier) should be asked "more thoroughly" to check the personalausweis (for example, once the server has verified the static card, a checkbox labeled "Ich habe die Daten mit einem amtlichen Lichtbildausweis abgeglichen" should be shown, and only once this checkbox is checked, it should show "Nürnberg-Pass ist gültig".)
Should we do this in another issue? I guess it shouldn't block this PR.
[ I haven't tested the PR yet; only Code Review ]
| @@ -42,6 +70,12 @@ void _assertConsistentDynamicVerifyCode(DynamicVerifyCode verifyCode) { | |||
| } | |||
| } | |||
|
|
|||
| void _assertConsistentStaticVerifyCode(StaticVerifyCode verifyCode) { | |||
| if (!verifyCode.hasPepper()) { | |||
| throw QrCodeFieldMissingException("hashSecretBase64"); | |||
There was a problem hiding this comment.
| throw QrCodeFieldMissingException("hashSecretBase64"); | |
| throw QrCodeFieldMissingException("pepper"); |
There was a problem hiding this comment.
So is it called pepper when there is no totpSecret and hashSecretBase64 when there is a totpSecret?
There was a problem hiding this comment.
no, it is always called papper :) We renamed it a few weeks ago from hashSecret to pepper, but there might be a few occurences left to fix
sarahsporck
force-pushed
the
675-support-static-qr-codes
branch
2 times, most recently
from
6a20981 to
ea3c09a
Compare
|
I would prefer to add the checkbox in a separate ticket, as I am really not familiar with how to build nice flutter ui and someone else can do this in half the time I'd need. Therefore I'll create an issue for this. |
sarahsporck
force-pushed
the
675-support-static-qr-codes
branch
from
ea3c09a to
8eae24c
Compare
sarahsporck
force-pushed
the
675-support-static-qr-codes-frontend
branch
from
4c58936 to
fc6bb19
Compare
|
Is there already a task? |
No description provided.