Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

512: categories nuernberg #709

Merged
merged 3 commits into from
Jan 12, 2023
Merged

512: categories nuernberg #709

merged 3 commits into from
Jan 12, 2023

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Jan 12, 2023 •
edited
Loading

  • Added categories for nuernberg
  • filter categories depending on build-config values for the filter_bar

resolves #512

michael-markl
michael-markl approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will see if something's missing once we add in the stores :)

frontend/lib/category_assets.dart Show resolved Hide resolved
@f1sh1918 f1sh1918 marked this pull request as ready for review January 12, 2023 13:46
@f1sh1918 f1sh1918 requested a review from maxammann as a code owner January 12, 2023 13:46
@f1sh1918 f1sh1918 enabled auto-merge January 12, 2023 13:52
@f1sh1918 f1sh1918 merged commit 3363fa5 into whitelabel Jan 12, 2023
@f1sh1918 f1sh1918 deleted the 512-categories-nuernberg branch January 12, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-markl michael-markl michael-markl approved these changes

@maxammann maxammann Awaiting requested review from maxammann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new categories with icons for Nürnberg
2 participants
@f1sh1918 @michael-markl