Fix map bugs #682
Merged
Fix map bugs #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
force-pushed
the
fix-map-bugs
branch
from
f306b7d to
8379128
Compare
|
Testing right now.
|
maxammann
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
The first bug was fixed by querying the coordinates from the geometry of the map feature.
I fixed the second bug by removing a previous hack (which seems to be unnecessary by now). This luckily resolved the crash.
Please test this thoroughly:
With and without location permissions enabled, check whether all animations look correct (and that the animation does not stop early which was the reason for the hack).