Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

625: Application end screen #648

Merged
merged 9 commits into from
Dec 14, 2022
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Nov 30, 2022

  • implement application end screen dialog
  • clear form data

If there is a proper text or text template to use, just let me know

Added issue for deep linking that has to be discussed #661

@f1sh1918 f1sh1918 requested a review from maxammann as a code owner November 30, 2022 12:58
Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maxammann
Copy link
Member

(Not tested yet)

@f1sh1918 f1sh1918 force-pushed the 625_Application_end_screen branch from 63f2619 to 8c1de9f Compare December 7, 2022 12:50
@f1sh1918 f1sh1918 force-pushed the 625_Application_end_screen branch from 8c1de9f to 385f840 Compare December 7, 2022 12:51
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@f1sh1918 f1sh1918 enabled auto-merge December 14, 2022 09:35
@f1sh1918 f1sh1918 merged commit 54cb77b into whitelabel Dec 14, 2022
@f1sh1918 f1sh1918 deleted the 625_Application_end_screen branch December 14, 2022 09:47
@f1sh1918 f1sh1918 mentioned this pull request Dec 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants