Integrate build configs into flavors #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/android/app/build.gradle
maxammann
requested review from
michael-markl,
sarahsporck and
f1sh1918
and removed request for
michael-markl
michael-markl
approved these changes
Dec 25, 2022
| @@ -16,7 +16,7 @@ | |||
| <option name="taskNames"> | |||
| <list> | |||
| <option value="run" /> | |||
| <option value="--args="execute"" /> | |||
| <option value="--args="create-admin bayern.ehrenamtskarte.app REGION_MANAGER [email protected] Administrator! 1"" /> | |||
| </list> | |||
| </option> | |||
| <option name="vmOptions" value="" /> | |||
There was a problem hiding this comment.
Please readd the Run backend run config
There was a problem hiding this comment.
Forgot to push something, fixed
There was a problem hiding this comment.
Are you sure you fixed it? I can't see it in the commits.
Co-authored-by: Michael Markl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select the build config based on a flavor instead of a gradle project property. Not sure if this is the way to go.
We are also hitting: pikaju/flutter-maps-launcher#27
If builds succeed then this is ready for review