Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Application Form on Error or on Version-Change #637

Merged
merged 7 commits into from
Dec 5, 2022

Conversation

michael-markl
Copy link
Member

This resets the application form if

  1. the version of the application form changes. The version is determined by the commit id that touched the administration/src/application folder the last time.
  2. an error occurs while rendering (this shouldn't happen in production, but acts as a safety net. For dev, it might happen when fiddling around with the application form)

(Fun fact: I tried hard to make GitHub recognize, I just renamed the useLocallyStoredState file and appended some content, but it just didn't want to understand that in its diff... 🙀 )

Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

administration/application_commit.sh Show resolved Hide resolved
administration/package.json Show resolved Hide resolved
Base automatically changed from add-stepper-to-application to whitelabel December 5, 2022 09:49
@maxammann maxammann merged commit 23a1b73 into whitelabel Dec 5, 2022
@maxammann maxammann deleted the reset-form-onchange branch December 5, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants