1678: Change filename of single card pdf #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztefanie
requested review from
steffenkleinle,
f1sh1918 and
seluianova
as code owners
steffenkleinle
approved these changes
Nov 15, 2024
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adjusted pdf filenames for single cards to owner name for nuernberg and bayern
Side effects
none
Testing
Create a single card in nuernberg or bayern -> filename should be firstname lastname.pdf
create multiple cards in nuernberg or bayern -> filename should stay as it is berechtigungskarten.pdf
koblenz card creation should stay as it is
Resolved issues
Fixes: #1678 #1756