-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1422: Create PDF for koblenz pass #1764
Conversation
I think Daniel mentioned that we should use the Koblenz font on the pdf. Will check the PR next week :) |
I used the final pdf koblenz sent us today that we should use. If they would have wanted a different font on this pdf, they would have sent it to us. |
Yes but if you compare the fonts on the ausweis part and the texts it differs. So if you fill helvetica there it will not fit together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Seems like there is leaner way to implement a custom font.
So good work 👍
I'm not 100% sure of the error handling is good enough.
Its very unlikely that a local font can't be found but if i rename the font in the public folder, so that it can't be found i get an unhandled error
@hauf-toni
i think to improve the scanning we should add a slight border around both qr codes in the template
improved the error handling |
I now get the using fallback message but still get uncaught runtime errors @ztefanie |
that is normal behaviour in dev environments. just close it, the pdf should be downloaded anyways |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on chrome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Tested on firefox
Short description
Adjusted to koblenz PDF to the final design
Side effects
None
Testing
Create a card and check the layout of the activation PDF, check the deep-link area, check if long names are displayed properly
Resolved issues
Fixes: #1422