Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1422: Create PDF for koblenz pass #1764

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Conversation

ztefanie
Copy link
Member

@ztefanie ztefanie commented Nov 8, 2024

Short description

Adjusted to koblenz PDF to the final design

Side effects

None

Testing

Create a card and check the layout of the activation PDF, check the deep-link area, check if long names are displayed properly

Resolved issues

Fixes: #1422

@f1sh1918
Copy link
Contributor

f1sh1918 commented Nov 8, 2024

I think Daniel mentioned that we should use the Koblenz font on the pdf. Will check the PR next week :)

@ztefanie
Copy link
Member Author

ztefanie commented Nov 8, 2024

I think Daniel mentioned that we should use the Koblenz font on the pdf. Will check the PR next week :)

I used the final pdf koblenz sent us today that we should use. If they would have wanted a different font on this pdf, they would have sent it to us.

@f1sh1918
Copy link
Contributor

I think Daniel mentioned that we should use the Koblenz font on the pdf. Will check the PR next week :)

I used the final pdf koblenz sent us today that we should use. If they would have wanted a different font on this pdf, they would have sent it to us.

Yes but if you compare the fonts on the ausweis part and the texts it differs. So if you fill helvetica there it will not fit together

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Seems like there is leaner way to implement a custom font.
So good work 👍

I'm not 100% sure of the error handling is good enough.
Its very unlikely that a local font can't be found but if i rename the font in the public folder, so that it can't be found i get an unhandled error

@hauf-toni
i think to improve the scanning we should add a slight border around both qr codes in the template

image

administration/src/cards/PdfFactory.ts Outdated Show resolved Hide resolved
@ztefanie
Copy link
Member Author

I'm not 100% sure of the error handling is good enough. Its very unlikely that a local font can't be found but if i rename the font in the public folder, so that it can't be found i get an unhandled error

improved the error handling

@f1sh1918
Copy link
Contributor

f1sh1918 commented Nov 13, 2024

I'm not 100% sure of the error handling is good enough. Its very unlikely that a local font can't be found but if i rename the font in the public folder, so that it can't be found i get an unhandled error

improved the error handling

I now get the using fallback message but still get uncaught runtime errors @ztefanie
image

@ztefanie
Copy link
Member Author

I'm not 100% sure of the error handling is good enough. Its very unlikely that a local font can't be found but if i rename the font in the public folder, so that it can't be found i get an unhandled error

improved the error handling

that is normal behaviour in dev environments. just close it, the pdf should be downloaded anyways

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on chrome

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Tested on firefox

administration/src/cards/PdfFactory.ts Outdated Show resolved Hide resolved
administration/src/cards/PdfFactory.ts Show resolved Hide resolved
@ztefanie ztefanie merged commit 28e12eb into main Nov 14, 2024
1 check passed
@ztefanie ztefanie deleted the 1422-create-pdf-for-koblenz-pass branch November 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PDF for Koblenz Pass
3 participants