1650: Adjust self service texts #1748
Conversation
f1sh1918
requested review from
steffenkleinle,
ztefanie and
seluianova
as code owners
f1sh1918
force-pushed
the
1650-adjust-self-service-texts
branch
from
e8784a5
to
99c9f5c
Compare
| <ActionButton href={deepLink} variant='contained' size='large'> | ||
| Pass aktivieren | ||
| KoblenzPass jetzt aktivieren |
There was a problem hiding this comment.
Please use APP_NAME constant instead
There was a problem hiding this comment.
Same for other occurrences :)
| @@ -11,20 +11,28 @@ const Container = styled('div')` | |||
| flex-direction: column; | |||
| ` | |||
|
|
|||
| const StyledIconTextButton = styled(IconTextButton)` | |||
| color: #131314; | |||
There was a problem hiding this comment.
Please move this to name constant that is reusable.
| @@ -64,7 +64,7 @@ const CardSelfServiceForm = ({ | |||
| return ( | |||
| <> | |||
| <Container key={card.id}> | |||
| <FormGroup label='Vorname Nachname'> | |||
| <FormGroup label='Vorname Name'> | |||
| align-items: center; | ||
| margin-bottom: 12px; | ||
| color: #595959; |
There was a problem hiding this comment.
Please move this to a named constant
There was a problem hiding this comment.
i think it makes more sense to define a colors file at some point and define there everything. This is sth that should be created and used project wide.
I will create a ticket for that
| <ActionButton href={deepLink} variant='contained' size='large'> | ||
| Pass aktivieren | ||
| KoblenzPass jetzt aktivieren |
There was a problem hiding this comment.
Same for other occurrences :)
Hm I think a text line break should also help. I will adjust that. Thx for the hint |
Short description
Finalize texts except hints and error messages (separate issue)
Proposed changes
Side effects
Testing
design
Resolved issues
Fixes: #1650