1713: Fix MailNotification validation in CSV import

[steffenkleinle]

Short description

Fix MailNotification validation in CSV import.

Proposed changes

• Use default extension state if not provided
• Show - if string is empty

Side effects

None.

Testing

1. Go to http://localhost:3000/cards/import
2. Import bulk data
3. See the mail notification field error validation while cards can be created

Resolved issues

Fixes: #1713

[f1sh1918]

Looks good. tested on chrome

[seluianova]

Could you please provide a csv example to reproduce the issue?
I tried this, MailNotification is empty, but I don't get a validation error on the main branch.

Name,Ablaufdatum,Kartentyp,MailNotification
Qwerty,,Goldkarte,

[f1sh1918]

Could you please provide a csv example to reproduce the issue? I tried this, MailNotification is empty, but I don't get a validation error on the main branch.

Name,Ablaufdatum,Kartentyp,MailNotification
Qwerty,,Goldkarte,

you can use the one in the repo on the main branch (resources/bulk-bavaria) it should be marked red

[steffenkleinle]

Could you please provide a csv example to reproduce the issue? I tried this, MailNotification is empty, but I don't get a validation error on the main branch.

Name,Ablaufdatum,Kartentyp,MailNotification
Qwerty,,Goldkarte,

you can use the one in the repo on the main branch (resources/bulk-bavaria) it should be marked red

Exactly. The error was shown if MailNotification is not present at all in the csv.

[seluianova]

The error was shown if MailNotification is not present at all in the csv.

💭 okay, than it works as requested, but tbh I would expect 'missing column' error in such case, because this column is specified in csv format:

there is no clue, that this column can be ommited.
also I think it would be nice to mark mandatory columns with an * in the table view, when not all of them are mandatory.

[seluianova]

not sure if the thought above should block this PR, so adding my approval anyway

[steffenkleinle]

The error was shown if MailNotification is not present at all in the csv.

💭 okay, than it works as requested, but tbh I would expect 'missing column' error in such case, because this column is specified in csv format

Yes, it is specified since it can also be passed to allow for automatic email notifications.

there is no clue, that this column can be ommited. also I think it would be nice to mark mandatory columns with an * in the table view, when not all of them are mandatory.

Sounds like a good addition. I'll create a new issue for this. We could also do something like MailNotification (optional) or have a second sentence with something like optional columns are.....

Edit: New issue: #1738