Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused assets #1714

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Delete unused assets #1714

merged 1 commit into from
Oct 30, 2024

Conversation

ztefanie
Copy link
Member

Short description

Deleted assets that are unused.

Side effects

  • maybe somewhere the icons are missing

Testing

Check the frontend for missing or wrongly sized icons

Resolved issues

Fixes: #1712

Base automatically changed from adjust-koblenz-icons to main October 28, 2024 15:45
f1sh1918
f1sh1918 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build every app on android and opened it. Looks good for me

seluianova
seluianova approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@seluianova seluianova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сhecked every app too and found no issues 👍

@f1sh1918 f1sh1918 merged commit 7151042 into main Oct 30, 2024
1 check passed
@f1sh1918 f1sh1918 deleted the 1712-refactor-assets branch October 30, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seluianova seluianova seluianova approved these changes

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

Assignees
No one assigned
Labels
not-testable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor assets
3 participants
@ztefanie @f1sh1918 @seluianova