Ignore intellij settings and use prettier code style

[steffenkleinle]

Short description

I frequently have changes to my intellij setting files which is rather annoying as I sometimes commit them accidentally.

Proposed changes

• Use code style from prettierrc
• Add inspection profiles to gitignore

Side effects

None.

Testing

None.

Resolved issues

Fixes: None.

[ztefanie]

Why do we not want to share settings of this? Can't we agree on some settings and keep sharing this file?

[steffenkleinle]

Hmmm, I am okay with adding this, but I think this just defines whether eslint is run by IntelliJ and errors are shown in the editor. I just figured that sometimes manual configuration is needed as automatic eslint config might not work for everybody.

[ztefanie]

I know you are waiting for reviews on this, but I am not really happy with the solution you provided and i do currently have no time / priority in having a deeper look into this.

The solution i would prefer is

• telling intellij to use code styled defined in es lint / prettier
• autoformat on save
• share all these settings for intellij with the whole team

[steffenkleinle]

I know you are waiting for reviews on this, but I am not really happy with the solution you provided

What exactly do you not like about this? This is just a small PR for me to finally get rid of all those uncommitted changes which are really annoying. I don't think this worsens behavior in comparison to the current state. Adding inspectionProfiles to .gitignore does not change IntelliJ settings for anyone. The adjusted code style is just for generated code from IntelliJ, e.g. auto imports and so on and would be needed in any case.

The solution i would prefer is

* telling intellij to use code styled defined in es lint / prettier

* autoformat on save

* share all these settings for intellij with the whole team

I definitely see the point and I think this might make sense, but I also see why someone would not want this. In any case, if you'd like additional things to be done, please create an issue for it. It does not really have anything to do with what I did here (except its also IntelliJ configuration).

[ztefanie]

I know you are waiting for reviews on this, but I am not really happy with the solution you provided

What exactly do you not like about this? This is just a small PR for me to finally get rid of all those uncommitted changes which are really annoying. I don't think this worsens behavior in comparison to the current state. Adding inspectionProfiles to .gitignore does not change IntelliJ settings for anyone. The adjusted code style is just for generated code from IntelliJ, e.g. auto imports and so on and would be needed in any case.

The solution i would prefer is

* telling intellij to use code styled defined in es lint / prettier

* autoformat on save

* share all these settings for intellij with the whole team

I definitely see the point and I think this might make sense, but I also see why someone would not want this. In any case, if you'd like additional things to be done, please create an issue for it. It does not really have anything to do with what I did here (except its also IntelliJ configuration).

I do not want any additional things to be done. But adding inspectionProfiles to .gitignore is a step in the wrong direction. I would rather enforce more shared settings, than less. This PR makes it "worse" in this point.

[ztefanie]

Andy and I both do not have the problem with the inspection profiles being created, so this seems to be more a local problem of your setup that should be fixed locally.

Edit: maybe you can share these inspection profiles and we can check if we want them for all of us commited here?

[steffenkleinle]

I know you are waiting for reviews on this, but I am not really happy with the solution you provided

What exactly do you not like about this? This is just a small PR for me to finally get rid of all those uncommitted changes which are really annoying. I don't think this worsens behavior in comparison to the current state. Adding inspectionProfiles to .gitignore does not change IntelliJ settings for anyone. The adjusted code style is just for generated code from IntelliJ, e.g. auto imports and so on and would be needed in any case.

The solution i would prefer is

* telling intellij to use code styled defined in es lint / prettier

* autoformat on save

* share all these settings for intellij with the whole team

I definitely see the point and I think this might make sense, but I also see why someone would not want this. In any case, if you'd like additional things to be done, please create an issue for it. It does not really have anything to do with what I did here (except its also IntelliJ configuration).

I do not want any additional things to be done. But adding inspectionProfiles to .gitignore is a step in the wrong direction. I would rather enforce more shared settings, than less. This PR makes it "worse" in this point.

Alright, I'll just revert the change. Atm I don't have any inspection profiles, but will push them if they ever reappear.