1431: Add app build config app #1654
Conversation
Updates to support xcode 16
…lfabrik/entitlementcard into 1431-add-app-build-config-koblenz
| export { default as buildConfigBayern } from "./bayern" | ||
| export { default as buildConfigKoblenz } from "./koblenz" | ||
| export type { DeeplLinkingConfig, BuildConfigType } from "./types" | ||
| export * from "./constants" |
There was a problem hiding this comment.
🔧 I think your formatting is off (double vs single quotes).
There was a problem hiding this comment.
Same for other files. Shouldn't this be caught by the CI pipeline/prettier?
There was a problem hiding this comment.
It is quite inconsistent currently, as these ts files are unter /frontend and prettier is only in /administration. See e.g. build-config/bayern/index has also double quotes. I can adjust this, but i would prefer to do it in a separate PR, so this PR does not get too big.
There was a problem hiding this comment.
Oh okay, thanks. Yes, then a separate PR makes sense.
|
Tested on pixel 7 and found two minor issues. 1.There is an overflow of the id card widget. Since we are not releasing this it can be fixed later but we should keep this in mind 2.I also get an error in the console when starting the app flutter: Environment: local
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Unable to load asset: "assets/koblenz/l10n/override_en.json".To fix deeplinking: I don't think we need a separate task for this one liner. |
When building administration in the build folder there are the files apple-app-site-association and assentlinks.json for each project |
They are already in the issue in the description of the PR, i added the console output for the missing english translations |
okay i didn't find adjust theme color, so i added this to #1653 |
Short description
Added app build config for koblenz
Proposed changes
Still open tasks due to currently still missing data will be done in #1653
Known issue, will be fixed in separate task: #1686
Testing
Start the app with koblenz flavour
check if deep link files are created properly
check on android and ios
check if correct intro screens and images / icons are displayed
check if correct publisher text is displayed
check if map is centered correctly to koblenz
Resolved issues
Fixes: #1431