Do not send stack traces in GraphQL responses #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
requested review from
steffenkleinle,
f1sh1918,
ztefanie and
seluianova
as code owners
michael-markl
force-pushed
the
1538-dont-send-stack-traces
branch
from
c0012c0
to
607d69c
Compare
michael-markl
changed the title
f1sh1918
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
To remove the stack traces from the Graphql errors, I had to remove the usage of
GraphqlErrorExceptionas it always serializes the whole exception including stacktrace.Proposed changes
Make
GraphQLBaseExceptionno longer inherit from the above mentionedGraphqlErrorExceptionand implement a custom DataFetcherExceptionHandler that only wraps unknown exceptions intoExceptionWhileDataFetchingobjects and converts the known ones (ie. the subclasses of GraphQLBaseException) into GraphQLErrors without wrapping it.If an ExceptionWhileDataFetching occurs, the wrapped exception is rethrown and either handled by
handleif it's a 40x error, or by Javalin (if it's a completely unexpected exception) and then a 500 is returned and the exception is logged by Javalin.Side effects
Hopefully none.
Resolved issues
Fixes: #1538