Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1039: add mime type text/csv for firefox ubuntu #1181

Merged
merged 2 commits into from
Oct 20, 2023
Merged

1039: add mime type text/csv for firefox ubuntu #1181

merged 2 commits into from
Oct 20, 2023

Conversation

sarahsporck
Copy link
Contributor

Short description

I'm pretty sure, that this fixes the problem, although I'm not sure why it occurs in the first place 🤷🏼‍♀️ .

Proposed changes

  • add accept header for text/csv to input

Side effects

  • Technically nothing, but please still test wether the csv upload still works for you and this change will not have an implication on existing working functionality.

Resolved issues

Fixes: #1039

f1sh1918
f1sh1918 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested

@sarahsporck sarahsporck merged commit 5668c35 into main Oct 20, 2023
1 check passed
@sarahsporck sarahsporck deleted the 1039-cant-upload-csv-in-firefox-live-system branch October 20, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't upload csv in firefox live system
2 participants
@sarahsporck @f1sh1918