Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1154 split circleci config #1166

Merged
merged 2 commits into from
Oct 16, 2023
Merged

1154 split circleci config #1166

merged 2 commits into from
Oct 16, 2023

Conversation

ztefanie
Copy link
Member

@ztefanie ztefanie commented Oct 12, 2023 •
edited by f1sh1918
Loading

Short description

Have a look at the second commit, as the first one is just the splitting up with no other changes.

Proposed changes

  • Splitted up config file
  • added a check for valid config file
  • added script to build config file
  • added workflow "commit" for checks that should be done for every commit, as the current flow is spending a lot of circleci credits unnecessarily

TODO before merging

  • adjust github settings to execute the commit workflow instead of frontend and backend workflows

Resolved issues

Fixes: #1154

@ztefanie ztefanie force-pushed the 1154-split-circleci-config branch from e165b87 to e2650c7 Compare October 12, 2023 09:14
@ztefanie ztefanie force-pushed the 1154-split-circleci-config branch from e2650c7 to d5bfc66 Compare October 12, 2023 09:16
f1sh1918
f1sh1918 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except of the not working update script for me
Update: you can ignore that just got it work
bash scripts/circleci-update-config.sh

f1sh1918
f1sh1918 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@ztefanie ztefanie merged commit 9cc5cb4 into main Oct 16, 2023
1 check passed
@ztefanie ztefanie deleted the 1154-split-circleci-config branch October 16, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@sarahsporck sarahsporck Awaiting requested review from sarahsporck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split up circleci config
2 participants
@ztefanie @f1sh1918