Extract linting rules into separate file #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
reviewed
Aug 29, 2023
| @@ -16,7 +15,7 @@ const CreateCardsButtonBar = ({ cardBlueprints, generateCards, goBack }: CreateC | |||
| return ( | |||
| <ButtonBar> | |||
| <Button icon='arrow-left' text='Zurück zur Auswahl' onClick={goBack} /> | |||
| <Tooltip2 | |||
| <Tooltip | |||
There was a problem hiding this comment.
why did you switch to tooltip?
There was a problem hiding this comment.
Actually, I only switched because the tests had problems at first, and I assumed it was related to the deprecated Tooltip2 component. I can change it back in this PR, but at some point we (again) might want to move away from deprecated components (-> #1001 )
There was a problem hiding this comment.
ok i'm fine. dunno if the disappearing problem also occurs with tooltip2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rule
prefer-templateand usereact-app/jestinstead ofjest/recommendedandjest/style.