Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1063: print cardInfoHash on pdf #1095

Merged
merged 3 commits into from
Aug 23, 2023
Merged

1063: print cardInfoHash on pdf #1095

merged 3 commits into from
Aug 23, 2023

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Aug 22, 2023

resolves #1063

i didn't see the need to shorten the hash? Any opinions?

@michael-markl
Copy link
Member

I'm fine with keeping the whole hash, but I think it is not perfectly aligned and a bit too small. Please consider merging in #1097 :)

@f1sh1918
Copy link
Contributor Author

I'm fine with keeping the whole hash, but I think it is not perfectly aligned and a bit too small. Please consider merging in #1097 :)

thx :) i merged please review my pr here

@f1sh1918 f1sh1918 merged commit 4af8f81 into main Aug 23, 2023
@f1sh1918 f1sh1918 deleted the 1063-card-info-hash-pdf branch August 23, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Druckerei] Print card info hash on pdf
2 participants