Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jest tests in administration #1093

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Conversation

sarahsporck
Copy link
Contributor

There are 2 reasons to migrate to jest:

  • Karma is deprecated
  • jasmine only supports spies, which makes it impossible to mock some values e.g URLSearchParameters

Therefore, this PR :)

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@@ -58,31 +58,25 @@
"bfj": "^7.0.2",
"browserslist": "^4.21.9",
"case-sensitive-paths-webpack-plugin": "^2.4.0",
"css-loader": "^6.8.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readded. I thought I added this, when I added some tests, but actually both css-loader and style loader are actually required.

@sarahsporck sarahsporck enabled auto-merge August 21, 2023 16:00
@sarahsporck sarahsporck force-pushed the migrate-to-jest-tests branch from 49592e2 to 00785f7 Compare August 21, 2023 16:06
@sarahsporck sarahsporck merged commit 689daaf into main Aug 21, 2023
@sarahsporck sarahsporck deleted the migrate-to-jest-tests branch August 21, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants