Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the validity of a card against the backend regularly #677

Closed
1 task
maxammann opened this issue Dec 19, 2022 · 4 comments · Fixed by #946
Closed
1 task

Check the validity of a card against the backend regularly #677

maxammann opened this issue Dec 19, 2022 · 4 comments · Fixed by #946
Labels

Comments

@maxammann
Copy link
Member

maxammann commented Dec 19, 2022

Is your feature request related to a problem? Please describe.

Disable cards which become invalid because of their expiration date or because they have been revoked, or because the same Anmeldecode was scanned twice.
Check if cards are still valid by verifying them against the backend.

An invalid card should stay in the app but it should be grayed out or a thick text should be displayed above it.

If the card becomes valid again then enable it again.

Describe the solution you'd like
TBD

Describe alternatives you've considered
None

Additional context
None

@maxammann
Copy link
Member Author

First non-revoked cards will expire probably early 2024.

@maxammann maxammann added the prio: high Issue must be solved within the next weeks. label Jan 9, 2023
@maxammann maxammann changed the title (Placeholder) Check the validity of a card against the backend regularly Check the validity of a card against the backend regularly Jan 10, 2023
@maxammann
Copy link
Member Author

@sarahsporck I think you planned to do this feature soon. Better pick some other issue as cards will not be become invalid soon.

@maxammann maxammann removed the prio: high Issue must be solved within the next weeks. label Feb 2, 2023
@f1sh1918
Copy link
Contributor

f1sh1918 commented Apr 19, 2023

Before implementing this feature we need the possibility to revoke cards in the administration, but this was not requested by the customer yet as urgent. It's even not clear if service user can change the expiration date. If not we don't have to check the backend for changes of this field (only revoke)

@michael-markl
Copy link
Member

It's even not clear if service user can change the expiration date. If not we don't have to check the backend for changes of this field (only revoke)

Changing expiration date is technically rather infeasible (as the expiration is printed onto the Anmeldecode).
Instead, it should be revoked and a new card should be issued.

Before implementing this feature we need the possibility to revoke cards in the administration, but this was not requested by the customer yet as urgent.

Revoking is not the only "dynamic" invalidation of cards: If you scan the same anmeldecode on another device, the card on the old device also gets invalidated. Hence, this should be taken care of before 2024 imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants