Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify imported Anmeldecodes #17

Closed
4 tasks done
PaulaWi opened this issue Nov 12, 2020 · 10 comments · Fixed by #730
Closed
4 tasks done

Verify imported Anmeldecodes #17

PaulaWi opened this issue Nov 12, 2020 · 10 comments · Fixed by #730
Assignees
Labels
prio: high Issue must be solved within the next weeks. Task user story

Comments

@PaulaWi
Copy link
Contributor

PaulaWi commented Nov 12, 2020

As an EAK owner, who received an anmeldecode (QR code), I want to authorize myself in the app to prove my status as EAK owner at accepting businesses.

Acceptance Criteria:

  • Generate a OTP from the anmeldecode before persisting it and verify the card.
  • Use the query fun verifyCardInProject(project: String, card: CardVerificationModel): Boolean
  • Validate that anmeldecode is valid, maybe make a request to the server with a generated hash to check that it actually works
  • Owner name, expiry date, random string and otp secret are saved locally in the app
@PaulaWi PaulaWi changed the title Authorization as EAK owner in App Authorization as EAK owner in app Nov 12, 2020
@PaulaWi PaulaWi added this to the Authorization Process milestone Nov 12, 2020
@RoAnBu
Copy link
Contributor

RoAnBu commented Dec 13, 2020

Option to provide recovery information (email address)

@PaulaWi
I would move that to a separate user story. For the beginning it might be a bit too much here.

An additional criteria could be: Tell the user that validation was succesful or that it failed

@maxammann
Copy link
Member

pdf generation: #166, #172

@maxammann
Copy link
Member

I think this is quite important. We should warn users if the QR code which was imported is not valid.

@maxammann maxammann added the discussion-needed We need to resolve the questions in the issue. label Jan 19, 2022
@maxammann maxammann removed this from the Authorization Process milestone Jan 19, 2022
@maxammann maxammann changed the title Authorization as EAK owner in app Check validity of imported Anmeldecodes Jan 19, 2022
@maxammann maxammann added this to the Working Verification milestone Jan 19, 2022
@maxammann maxammann changed the title Check validity of imported Anmeldecodes Verify imported Anmeldecodes Nov 21, 2022
@maxammann maxammann added prio: high Issue must be solved within the next weeks. and removed discussion-needed We need to resolve the questions in the issue. low prio labels Nov 21, 2022
@maxammann
Copy link
Member

This is now high priority because Nuernberg wants to be use the Anmeldecode for verifying that somebody is entitled.

@maxammann maxammann removed this from the Improved Verification milestone Nov 21, 2022
@michael-markl
Copy link
Member

@maxammann Are you still working on this?
I think this would be a good starter task for @f1sh1918 or @sarahsporck

@maxammann maxammann removed their assignment Jan 11, 2023
@maxammann
Copy link
Member

It would be a shame if I would work on this since 2 months :D

@michael-markl
Copy link
Member

Cool, @f1sh1918 and @sarahsporck : feel free to grab it if you re out of work :P

@michael-markl
Copy link
Member

michael-markl commented Jan 12, 2023

The issue description is quite old but still largely valid. I think you can ignore the third checkbox, if you don't understand its meaning (I am having a hard time too) :D

@sarahsporck sarahsporck self-assigned this Jan 13, 2023
@sarahsporck
Copy link
Contributor

Well, then this ticket belongs to me now! :)

@michael-markl
Copy link
Member

We'll most likely get many merge conflicts with #717 . I will help you in fixing them :)

@sarahsporck sarahsporck linked a pull request Jan 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high Issue must be solved within the next weeks. Task user story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants