Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Placeholder) Do not send verbose errors to frontend #324

Closed
maxammann opened this issue Mar 20, 2021 · 7 comments
Closed

(Placeholder) Do not send verbose errors to frontend #324

maxammann opened this issue Mar 20, 2021 · 7 comments
Labels
prio: high Issue must be solved within the next weeks. Task
Milestone
High-Prio After R...

Comments

@maxammann
Copy link
Member

maxammann commented Mar 20, 2021 •
edited
Loading

Currently the backend sends the plain error objects to the frontend when an error occurs. This is not a good behavior, because it can leak internal data.
image

TODO: Add a solution.
@maxammann maxammann added the Bug Something isn't working label Mar 20, 2021
@michael-markl
Copy link
Member

@maxammann I think this is not a bug in production, is it?

@maxammann
Copy link
Member Author

Probably not, but I'd leave this task open until someone checked a crash like this again.

@maxammann maxammann changed the title Do not send verbose errors to frontend (Needs repoduction) Do not send verbose errors to frontend Jan 19, 2022
@maxammann
Copy link
Member Author

I just observed this again on the current deployment

@maxammann maxammann changed the title (Needs repoduction) Do not send verbose errors to frontend Do not send verbose errors to frontend Nov 9, 2022
@maxammann maxammann added prio: high Issue must be solved within the next weeks. and removed low prio labels Nov 9, 2022
@maxammann maxammann changed the title Do not send verbose errors to frontend (Placeholder) Do not send verbose errors to frontend Dec 19, 2022
@michael-markl michael-markl mentioned this issue Dec 19, 2022
Merged
@michael-markl
Copy link
Member

A solution to this issue should introduce a general concept of how to treat errors in the GraphQL backend (& interface)

@maxammann
Copy link
Member Author

Yes absolutely! Now that we know why these messages show up in the frontend this is a technical task.

@maxammann maxammann added Task and removed Bug Something isn't working labels Dec 19, 2022
@maxammann
Copy link
Member Author

Very much related to #659

@michael-markl michael-markl mentioned this issue Mar 19, 2023
Merged
@sarahsporck sarahsporck mentioned this issue Mar 20, 2023
Closed
@sarahsporck
Copy link
Contributor

Should be resolved due to #873, as all backend exceptions have their own error message now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: high Issue must be solved within the next weeks. Task
Projects
None yet
Milestone
High-Prio After Release
Development

No branches or pull requests
3 participants
@maxammann @michael-markl @sarahsporck