836: Send verification emails

[sarahsporck]

If one email cannot be sent (, e.g. because of invalid from address) then the application is not persisted.

[michael-markl]

If one email cannot be sent (, e.g. because of invalid from address) then the application is not persisted.

Hmm... Not sure if this is a good approach. I think it would be a good approach, if the user got a proper error message when trying to submit the application. Without a proper error message, the user would have to guess what the problem is...

[sarahsporck]

If one email cannot be sent (, e.g. because of invalid from address) then the application is not persisted.

Hmm... Not sure if this is a good approach. I think it would be a good approach, if the user got a proper error message when trying to submit the application. Without a proper error message, the user would have to guess what the problem is...

I think we generally are really wonky with our error handling. Imo the graphql interface should always return sth like .

{
    "status": <http_status_like>,
    "message": <maybe_optional_because_of_translations>,
    "result": <only_for_queries>
}

I'll open an issue for this.
In this case though I think it is often logical to fail here. But you are right. A better error message should be displayed, although I'm unsure what to return in an error case.

[michael-markl]

I think we generally are really wonky with our error handling. Imo the graphql interface should always return sth like .

We are super wonky, we never introduced a concept for handling errors^^

Related: #324

The alternative to your suggestion is to use the graphql philosophy and use/improve GraphQL errors: https://www.apollographql.com/docs/react/data/error-handling/

[sarahsporck]

If one email cannot be sent (, e.g. because of invalid from address) then the application is not persisted.

After thinking about this a while I think this is pretty difficult to handle. consider two emails already have been sent and one failed. In that case the organization mitarbeiter will still receive emails with an (invalid) link then, which feels much like spam to me. Therefore I reconsidered that we do not roll back here and let the mitarbeiter of the region handle the situation which would go like this in the optimal situation.
An application with three organisations has been created. And sending the mail to two of the organisations has worked fine. However, one failed. The two organisations will verify the application successfully, but the one who has not received the email address has not. In that case the mitarbeiter of the entitlementcard will contact the mitarbeiter at the organization him:herself after maybe 2 weeks.
Showing an error to the applicant in this case has no benefit I think, as he:she cannot interfere or improve the situation. I think the best solution regarding "usability" would be to set the verification in an error state in the db, to let the mitarbeiter of the entitlementcard know he:she has to interfere.