Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move signature log entries before expiry check #26

Merged
merged 2 commits into from
Sep 30, 2024
Merged

move signature log entries before expiry check #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e61e16
move signature log entries before expiry check
jchartrand Sep 26, 2024
ec665d1
update version and changelog
jchartrand Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,9 @@ async function _verifyCredential(options = {}) {
}
}

log.push({id: 'valid_signature', valid: true});
log.push({id: 'issuer_did_resolves', valid: true});

// run common credential checks (add check results to log)
_checkCredential({credential, log, now});

Expand All @@ -362,9 +365,6 @@ async function _verifyCredential(options = {}) {
'"credentialStatus".');
}

log.push({id: 'valid_signature', valid: true});
log.push({id: 'issuer_did_resolves', valid: true});

if(credential.credentialStatus) {
await addStatusInfoToLog({options, result, log});
}
Expand Down
Loading