Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VC 2.0 data model #5

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Implement VC 2.0 data model #5

merged 4 commits into from
Mar 26, 2024

Conversation

kezike
Copy link
Contributor

@kezike kezike commented Mar 4, 2024

This PR adds/modifies fields for the VC 2.0 data model.

@kezike kezike requested a review from dmitrizagidulin March 4, 2024 04:33
@dmitrizagidulin
Copy link
Member

@kezike why the addition of ; everywhere? The original library is going for a more Standard.js no-semicolon style.

id: string
type: Type
[x: string]: any
id?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Member

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice job on this. (I'd slightly prefer to go the non-semicolon route, tho.)

@dmitrizagidulin
Copy link
Member

Merging, thanks!

@dmitrizagidulin dmitrizagidulin merged commit 11f2d34 into main Mar 26, 2024
3 checks passed
@dmitrizagidulin dmitrizagidulin deleted the feature/add-vc-2.0 branch March 26, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants