checks client's authority to manage status repos during initialization #21
Conversation
| throw new Error(`One or more of the access tokens you are using for the credential status repo ("${repoName}") and the credential status metadata repo ("${metaRepoName}") are incorrect or expired.`); | ||
| } | ||
|
|
||
| const reposExist = await statusManager.statusReposExist(); | ||
| if (!reposExist) { | ||
| throw new Error(`The credential status repo ("${repoName}") and the credential status metadata repo ("${metaRepoName}") must be manually created in advance.`); |
There was a problem hiding this comment.
Could the errors possibly be made explicit? So rather than Error, something like InvalidTokenError? And MissingRepositoryError? Just so that in the status-service, when catching the errors, they can more easily and reliably turned into http codes (e.g. 401 for the invalid token, 404 for the missing credential (not shown in the code snippet here, but is here:
) or otherwise deal with them.Or maybe there is some other way to deal with this?
There was a problem hiding this comment.
OK, so kinda like what I did for this error, yeah?
There was a problem hiding this comment.
Yes.
Looking at that error, though, I'm curious about these two lines:
credential-status-manager-git/src/errors.ts
Lines 22 to 23 in 5bd432c
i.e,
// Set the prototype explicitly.
Object.setPrototypeOf(this, StatusRepoInconsistencyError.prototype);
Why do you have to explicitly set the prototype? Wouldn't the new object's prototype already point at StatusRepoInconsistencyError.prototype?
There was a problem hiding this comment.
OK, I added a number of new errors to errors.ts, including InvalidTokenError and MissingRepositoryError, as recommended, and replaced all generic errors that are visible to the caller with these specific errors.
Also, I don't recall why I added that call to Object.setPrototypeOf. I have removed it for now.
Let me know if you have any other questions/concerns about my approach.
There was a problem hiding this comment.
Sorry, I just realized that I pushed those changes to an older branch that was already merged into this one. I just merged those updates into this branch.
…ue); implement ensureStatusCredentialContext inline instead
…mprove-misleading-access-token-error-message
This PR addresses Issue #16 by checking a client's authority to manage status repos during initialization and reporting an error message to the caller if not.