Initial implementation of a database status manager #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goDB credential status manager methods; refines base credential status manager methods; adds and throws additional error types
…entialSiteOrigin and makes it required; removes deployStatusCredentialWebsite method; improves error handling
…asePassword as required config options; refactors hasAuthority; adds code to error classes
jchartrand
approved these changes
Feb 5, 2024
…abaseTablesProperlyConfigured to getDatabaseState; adds check in getDatabaseState for match between value of statusCredentialSiteOrigin property in createStatusManager and preexisting value thereof in config database table; returns error message in getDatabaseState; adds support for undefined status credential ID in getStatusCredential; fixes update logic for allCredentialsIssuedCounter; changes read concern for database transactions from majority to local; implements WriteConflictError in order to enable continued attempts of update transactions; adds minor copy updates to variable names and comments
…st-test scripts; renames embedCredentialStatus to attachCredentialStatus; adds newUserCredential field to attachCredentialStatus output type in order to prevent unnecessary event creations; improves error reporting for mismatches in credential accounting; moves generateStatusCredentialId implementation back to class method; updates lint rules; fixes lint errors
…ME.md; applies minor copy updates
… from vc 1 to vc 2; validates credential as vc 1 or vc 2 during status allocation; updates interface of allocateStatus to be accept an object parameter with credential and statusPurpose; implements allocateRevocationStatus; implements revokeCredential; implements allocateSuspensionStatus; implements suspendCredential; removes credentialStatus and proof properties from credential during status allocation; signs credentials in tests; updates license info
|
PR looks good, though please use jsdoc style function comments (instead of the current |
…s allocateStatus method to accept an array of purposes instead of a single purpose; replaces credentialState with statusPurpose and invalidate in updateStatus input; replaces checkStatus with getStatus; adds full support for allocating and updating multiple status purposes
…cordById for untracked ids; implements getCredentialInfo as alias for getUserCredentialRecordById; renames allocateAllStatuses to allocateSupportedStatuses
… and explains credential counter check in getDatabaseState
This was referenced Apr 24, 2024
|
This PR is waiting on changes from @jchartrand and should not be merged yet. |
|
Done, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses digitalcredentials/credential-status-manager-git#22, by adding support for a database status manager.