Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selective use of md algorithms. #468

Closed
davidlehn opened this issue Jan 12, 2017 · 2 comments
Closed

Allow selective use of md algorithms. #468

davidlehn opened this issue Jan 12, 2017 · 2 comments
Assignees
Milestone

Comments

@davidlehn
Copy link
Member

As mentioned in #467, it should be possible to combine files without requiring all of the algorithms from md.js.

0.6.x was a bit more relaxed in what files got used but code conversion for 0.7.x made it more aggressive to just use all algorithms via the generic md.js.

One solution is to have md.js only setup the simple data structures and then individual algorithm files (ie, sha256.js) can be required by higher level code as needed. As a default, index.js (or some meta md file) could require all known algorithms.

@davidlehn
Copy link
Member Author

@alexlamsl: I think this addresses your concern from #467. You should be able to just bundle pbkdf2.js and sha256.js and the dependencies will pull in the other files. An example was added to the webpack file to do this. Please reopen if this doesn't fit your use case. Thanks.

@alexlamsl
Copy link

@davidlehn looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants