Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version #467

Closed
nigampatel opened this issue Jan 11, 2017 · 7 comments
Closed

New Version #467

nigampatel opened this issue Jan 11, 2017 · 7 comments
Milestone

Comments

@nigampatel
Copy link

When are you planning on cutting a new version? It seems like you have browserify issue resolved in master branch but no version has been cut for it?

@davidlehn
Copy link
Member

In the next few days. It would be helpful if people could test and provide feedback on the master branch. Check for general functionality and test that new things like browserify and webpack support are working as needed. There were a lot of changes and we've had very limited testing feedback.

@alexlamsl
Copy link

An issue with my use case is I only need pkbdf2() to use within web browsers.

In the current published version I can just package hmac.js, pbkdf2.js, sha256.js and util.js together and things will just work.

With the latest version, due to those new require('md') etc., I will end up with needing to import a lot more source files, e.g. sha512.js, in order to achieve the same functionality.

@davidlehn
Copy link
Member

@alexlamsl: Good point. I created a new issue for that and will try to make the require()s less aggressive to allow easier custom builds.

@nigampatel
Copy link
Author

I just stated looking at this and first thing I notice that when I require('node-forge') it added 275KB of javascript to my browserify bundle. That is a big file, I would agree with @alexlamsl to make this browser friendly.

@dlongley thank for creating the new issues to cover this.

@davidlehn
Copy link
Member

@nigampatel: Yes, the main build is large. It's actually slightly smaller now than it was before due to removal of some redundant boilerplate and other minor things. One goal of this next release is to minimize disruption for previous users so that default build will likely stay large. But the new setup should make custom builds much easier. And hopefully we can reduce dependencies and so on to make custom builds even smaller.

@joeheyming
Copy link

When is the due date?

@davidlehn
Copy link
Member

0.7.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants