Validate created #34
Validate created #34
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 90.52% 89.94% -0.58%
==========================================
Files 4 4
Lines 549 587 +38
==========================================
+ Hits 497 528 +31
- Misses 52 59 +7
Continue to review full report in Codecov by Sentry.
|
|
@dlongley removed the checks involving now and clockSkew and just throw if created is defined and does not match the RegExp (there's a test for it). LMK if this is ok and I can add it for expires to. I did keep the code to convert the timestamp to a Date. |
lib/DataIntegrityProof.js
Outdated
| async verifyProof({proof, proofSet, document, documentLoader}) { | ||
| async verifyProof({ | ||
| proof, proofSet, | ||
| document, documentLoader, | ||
| }) { |
There was a problem hiding this comment.
Can you revert this unnecessary change?
There was a problem hiding this comment.
reverted here: 0f66109
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
Adds a new minor feature created validation to DataIntegrityProof in the verify step.