Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary authorize "authority" in openid4vp URL. #119

Merged
merged 2 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# bedrock-vc-delivery ChangeLog

## 6.3.1 - 2024-11-dd

### Fixed
- Remove unnecessary `authorize` "authority" in openid4vp URL.

## 6.3.0 - 2024-10-14

### Added
Expand Down
2 changes: 1 addition & 1 deletion lib/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export async function addRoutes({app, service} = {}) {
client_id: `${openIdRoute}/client/authorization/response`,
request_uri: `${openIdRoute}/client/authorization/request`
});
protocols.OID4VP = `openid4vp://authorize?${searchParams}`;
protocols.OID4VP = `openid4vp://?${searchParams}`;
}
res.json({protocols});
}));
Expand Down
6 changes: 3 additions & 3 deletions test/mocha/34-oid4vp.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('exchange w/ OID4VP presentation w/DID Authn only', () => {
client_id: `${exchangeId}/openid/client/authorization/response`,
request_uri: authzReqUrl
});
const openid4vpUrl = 'openid4vp://authorize?' + searchParams.toString();*/
const openid4vpUrl = 'openid4vp://?' + searchParams.toString();*/

// exchange state should be pending
{
Expand Down Expand Up @@ -313,7 +313,7 @@ describe('exchange w/ OID4VP presentation w/VC', () => {
client_id: `${exchangeId}/openid/client/authorization/response`,
request_uri: authzReqUrl
});
const openid4vpUrl = 'openid4vp://authorize?' + searchParams.toString();
const openid4vpUrl = 'openid4vp://?' + searchParams.toString();

const protocolsUrl = `${exchangeId}/protocols`;
const response = await httpClient.get(protocolsUrl, {agent});
Expand Down Expand Up @@ -463,7 +463,7 @@ describe('exchange w/ OID4VP presentation w/VC', () => {
client_id: `${exchangeId}/openid/client/authorization/response`,
request_uri: authzReqUrl
});
const openid4vpUrl = 'openid4vp://authorize?' + searchParams.toString();
const openid4vpUrl = 'openid4vp://?' + searchParams.toString();

const protocolsUrl = `${exchangeId}/protocols`;
const response = await httpClient.get(protocolsUrl, {agent});
Expand Down
4 changes: 2 additions & 2 deletions test/mocha/backwards-compatibility/34-oid4vp.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe('exchanger backwards-compatibility: ' +
client_id: `${exchangeId}/openid/client/authorization/response`,
request_uri: authzReqUrl
});
const openid4vpUrl = 'openid4vp://authorize?' + searchParams.toString();*/
const openid4vpUrl = 'openid4vp://?' + searchParams.toString();*/

// exchange state should be pending
{
Expand Down Expand Up @@ -313,7 +313,7 @@ describe('exchanger backwards-compatibility: ' +
client_id: `${exchangeId}/openid/client/authorization/response`,
request_uri: authzReqUrl
});
const openid4vpUrl = 'openid4vp://authorize?' + searchParams.toString();
const openid4vpUrl = 'openid4vp://?' + searchParams.toString();
console.log('openid4vpUrl', openid4vpUrl);*/

// get authorization request
Expand Down