Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on macos #82

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Fix on macos #82

merged 2 commits into from
Nov 9, 2021

Conversation

akrmn
Copy link
Contributor

@akrmn akrmn commented Nov 4, 2021

With these two commits I was able to build this repo on macOS with hadrian/build.stack.sh --configure --flavour=quickest -j hadrian/build.stack.sh --configure --flavour=quickest -j --integer-simple.

The first commit was suggested by @cocreature, so thanks for that!

I took the second commit from a "temporary hack" I found on an issue in the archived hadrian repo, so I'm not sure if it's the best solution, or if it will cause any problems on Linux. I'll make a PR to daml to rule out the latter.

The second commit simply adds a qualified import of Prelude to the Parser.y file, since versions of Happy newer than 1.19 apparently don't automatically import the Prelude. This was also suggested by @cocreature :)

Finally, I still needed to add the --integer-simple flag to get a build on macOS. This is not ideal, but works for now. I've documented the workaround on the Working on ghc-lib guide in the corresponding daml PR

angerman and others added 2 commits November 8, 2021 14:10
_AC_PROG_CC_99 isn't available anymore in recent autoconf versions.
This broke on aarch64-darwin.
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akrmn akrmn merged commit 71fbb2d into da-master-8.8.1 Nov 9, 2021
@akrmn akrmn deleted the fix-on-macos branch November 9, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants